-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Aspect Workflows CI (on AWS + Buildkite) #154
Conversation
e1b8142
to
2f39676
Compare
831d6da
to
6614aa1
Compare
71d740a
to
fb0deff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels to me like we're defeating the purpose of showing real-life examples if we have a GitHub repo using GitLab CI/CD. Shouldn't we have a project hosted on GitLab for this?
I synced this one to GitLab so we have a demonstration repo that gets some traffic and is more than just a hello world: https://gitlab.com/aspect-build/rules_jest/-/pipelines. |
Yeah but the syncing part is pretty weird. Are rules_jest contributors going to have to understand their PRs getting synced and then the status checkmark is over on GitLab? |
I don't expect the GitLab CI checkmark will be load bearing here for contributors. Actually, I should add the buildifier check back in here since the GitLab CI check won't show up here. A GitLab first project sounds good once we figure one out. In the meantime, I'd like to land this so I have a live example for the GitLab trials starting. We can switch this deployment over to another CI host once we have a GitLab first repo. |
fb0deff
to
f4ce139
Compare
f4ce139
to
e05f89c
Compare
1ce6b66
to
2f93cba
Compare
2f93cba
to
c94a969
Compare
c94a969
to
f6fb084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will let Derek give the stamp
f6fb084
to
8a97a60
Compare
8a97a60
to
4f05e2e
Compare
Run CI on an Aspect Workflows deployment on AWS + Buildkite. Just the root WORKSPACE & buildifier for now.
Pipelines:
https://buildkite.com/aspect/rules-jest
https://buildkite.com/aspect/rules-jest-warming
These pipelines are part of the rules_jest Buildkite Cluster: https://buildkite.com/organizations/aspect/clusters/7c946573-2ac7-42a6-8b1e-4c17518cf97e/pipelines
I've included the terraform in this repo to serve as a live working example for the full configuration of Aspect Workflows for AWS + Buildkite.
Type of change
Test plan
Observe Aspect Workflows on Buildkite working.